Modernise CI-advanced workflow#54
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 62.09% 62.06% -0.03%
==========================================
Files 3 4 +1
Lines 153 203 +50
==========================================
+ Hits 95 126 +31
- Misses 58 77 +19 🚀 New features to boost your workflow:
|
|
Thanks @stertooy! Of course, this should be updated, the idea behind the package is that one can reuse it, so it should be the latest state of the art setup. |
|
Unfortunately this now has a conflict because I merged your other PR first |
|
Should be resolved now :) |
|
It says that there are still/again conflicts, unfortunately |
|
Huh? That's weird, for me it's displaying
|
|
That is so weird!... 
I'll try to work out what's happening and sort it out. Thanks for your changes! |
|
I see the same as Wilf. It can be merged, or squashed and merged, but it can't be rebased. |
|
Right... no idea why I couldn't see this on GitHub itself, but locally I could see the rebase conflicts. Hopefully it's resolved this time. |
|
Now it looks good and ready for the review (@fingolfin @wilfwilson). |
olexandr-konovalov
left a comment
olexandr-konovalov
left a comment
There was a problem hiding this comment.
LGTM but to be sure I'd like @fingolfin or @wilfwilson who may be better aware of the most recent features.
4 participants
The current
CI-advancedworkflow is quite outdated:In particular, some of the things this workflow was meant to showcase, such as installing additional system dependencies, are now incorporated into the various
gap-actionsand corresonding entries inPackageInfo.g.After updating this workflow, the only remaining difference with the standard
CIwas the installation of the development version ofnq... So I adapted this workflow to also demonstrate running on macOS and Windows.